Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOP Lesson0 Complete #1036

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

APekariev
Copy link

OOP Lesson0 Complete (Task done)

Comment on lines 18 to 22
if (foundUser != null) {
return foundUser.getPassword().equals(password);
} else {
return false;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (foundUser != null) {
return foundUser.getPassword().equals(password);
} else {
return false;
}
return foundUser != null && foundUser.getPassword().equals(password);

@@ -11,6 +13,12 @@ public class AuthenticationService {
* Return false in any other cases.
*/
public boolean login(String email, String password) {
return false;
UserService userService = new UserService();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it a private class field

@APekariev APekariev requested a review from okuzan May 7, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants